chore(server): make queue drivers generic #3135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielbdias
approved these changes
Sep 8, 2023
| @@ -1,6 +1,6 @@ | |||
| module github.com/kubeshop/tracetest/agent | |||
|
|
|||
| go 1.20 | |||
| go 1.21 | |||
danielbdias
reviewed
Sep 8, 2023
| } | ||
| } | ||
|
|
||
| type Pipeline[T any] struct { |
There was a problem hiding this comment.
I liked this approach of turning the Pipeline generic. This will help us to deal with other queues in the future.
jorgeepc
approved these changes
Sep 11, 2023
schoren
force-pushed
the
subscriber-drivers
branch
from
0088615 to
4df098a
Compare
schoren
force-pushed
the
subscriber-drivers
branch
from
f429c1a to
c6ded31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts the Queue module including its drivers into a reusable package through the use of generics. This sets the field to allow easy reuse in other modules